Repository navigation
fix(client): retry clearance as soon as a page returns from sleep - #93
Merged
Merged
Conversation
A renewal that failed while the page was hidden or offline no longer holds its backoff once the page is visible and online again. After a long sleep the token has expired, so waiting out that backoff left every protected request refused for minutes. One early retry per absence; a failure while the page is in view keeps its delay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a computer sleeps longer than the clearance token lasts, the browser can wake briefly in the background (for example macOS maintenance wakes), try to renew without a working network, fail, and back off. After the real wake the page waited out that backoff while protected requests were refused. In a real sleep test this took about three minutes.
Change
onlineevent fires, such a failure earns one immediate retry.onlineevents still cannot drive repeated requests (the existing test for that is unchanged).onlinelistener is removed with the session.Tests
Five new tests in
clearance-renewal.test.ts. The three behaviour tests fail on the old code; the other two guard against skipping the delay without an absence and against a leaked listener. Full client suite, typecheck, lint and build pass.